v0.1 editorial change suggestions #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table should cover all possible values for the field. Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
- Add a heading for `mttp` - Remove unnessary distinguishing between S-mode and HS-mode Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
- Sort the descriptions of the MTTL2 types in the same order as the
encoding binary values
- All MTT PTEs are the same size, not just non-leaf PTEs
- Correct issues with the algorithm description:
- Most references to "i" are off by one compared to the diagrams
because i=0 is not another table, but the bits within an entry
- The i<0 error condition is not possible due to the MTTL1 encoding
- Improve the wording of the MTTL1 interpretation step
- Software must assume caching is occuring; it has no way to know for
sure
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
- Fix copy-paste of RERI to I/O MTT - Add word "register" to improve readability - Fix PCIe BDF example table -- the bottom three rows are all intended to be NAPOT rules - `TEE_LIM` was previously renamed to `TEE_FLT` Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
- The interrrupt was previously renamed from "M-level" to "local" - Remove extra and repeated words Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
The pseudocode was inverted compared to the earlier description in the text and the following example. Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
SiFiveHolland
force-pushed
the
up/v0.1-review-fixes
branch
from
e3793c9
to
288fe9d
Compare
rsahita
reviewed
Sep 30, 2024
rsahita
reviewed
Sep 30, 2024
ved-rivos
approved these changes
Oct 1, 2024
This was referenced Oct 1, 2024
Co-authored-by: Ravi Sahita <rsahita@yahoo.com> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are non-functional changes to fix several typos and adjust some wording. See the individual commits for details.